Skip to content

Add command to delete empty messages #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2020
Merged

Add command to delete empty messages #349

merged 2 commits into from
Jan 18, 2020

Conversation

@axi
Copy link
Contributor

@axi axi commented Nov 26, 2019

translation:extract on a new lang currently export keys with empty string as translation, resulting in empty string being valid translations.
I prefer to delete empty translations than having empty string, so fallback can be used

@odolbeau
Copy link
Member

odolbeau commented Nov 27, 2019

Thanks @axi!
Nice move to create a new command to achieve this as it's not the behavior everyone expect.
For example, in my case I voluntary deal with empty translations to allow translators to add (or not) a translation in some places (like form help for example).

Anyway, before merging this PR, could you please add some tests? Thanks!

@rvanlaak
Copy link
Member

rvanlaak commented Nov 27, 2019 •
edited
Loading

What about extracting the actual behavior of deleting empty messages to it's own class? That will make it testable, reusable and a bit more framework-independent. ;-)

Can imagine removing empty messages would become useful as feature to enable in development mode sometime.

@Nyholm
Copy link
Member

Nyholm commented Jan 6, 2020

A small ping. Could you rebase the PR?

@axi
Copy link
Contributor Author

axi commented Jan 9, 2020

Should be rebased now

@Nyholm
Copy link
Member

Nyholm commented Jan 18, 2020

What about extracting the actual behavior of deleting empty messages to it's own class?

That is true for most (all?) our commands. I see this command is just a copy of DeleteObsoleteCommand.

I think it is fair to merge this and leave the refactoring to a separate PR.

Nyholm
Nyholm approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @axi.

Im just waiting for travis to be green.

@Nyholm Nyholm merged commit 6a0e645 into php-translation:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@axi @odolbeau @rvanlaak @Nyholm